Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage GitHub action #107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rafiramadhana
Copy link
Contributor

Relates to #101

Add a github action to publish code coverage using orgoro/coverage@v3.1.

@rafiramadhana
Copy link
Contributor Author

rafiramadhana commented Oct 29, 2023

@Iqrar99 it looks like we have issue with the PR permissions/token stuff

HttpError: Resource not accessible by integration
    at /home/runner/work/_actions/orgoro/coverage/v3.1/webpack:/typescript-action/node_modules/@octokit/request/dist-node/index.js:86:1
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

https://github.com/warnet-gi/WarnetBot/actions/runs/6684030106/job/18160849228?pr=107

do you have any clue? ty

@Iqrar99
Copy link
Member

Iqrar99 commented Oct 29, 2023

Hello @rafiramadhana, I have changed the default permission for GitHub Actions to be able doing read and write. Please give it a try again
image

@rafiramadhana
Copy link
Contributor Author

rafiramadhana commented Nov 1, 2023

@Iqrar99 Btw I just realised that I might hit the maximum access for pull requests from public forked repositories because I am using a forked repo.

I've done a small proof of concept using my own repo, and it succeed (rafiramadhana/python-cicd#4).

To solve this, I think you can try to do the PR by yourself using my commit.

Add calculate_elo test and code coverage action.
@rafiramadhana
Copy link
Contributor Author

@Iqrar99 I've squashed the commits to ease the cherry-pick. LMK if you have concerns or anything. Tx!

@Iqrar99 Iqrar99 added the testing Feature testing label Nov 1, 2023
@Iqrar99
Copy link
Member

Iqrar99 commented Nov 1, 2023

Thank you. I'll do it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Feature testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants